linux-kernel - Re: [PATCH v2 2/2] drm: bridge: adv7511: Add support for ADV7535

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc1b73b2-def6-2e54-defc-30fe73b8d82e@kontron.de>
Date:   Wed, 27 Nov 2019 14:46:43 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     "Togorean, Bogdan" <Bogdan.Togorean@...log.com>
CC:     "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "a.hajda@...sung.com" <a.hajda@...sung.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "sam@...nborg.org" <sam@...nborg.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "allison@...utok.net" <allison@...utok.net>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "matt.redfearn@...nci.com" <matt.redfearn@...nci.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>
Subject: Re: [PATCH v2 2/2] drm: bridge: adv7511: Add support for ADV7535

On 27.11.19 15:22, Togorean, Bogdan wrote:
> Hi Frieder,
> 
> I'm glad to find there are other persons interested in this driver and
> especially support for ADV7535. Unfortunately I had to put on hold the
> development due to other activities but I'll send V3 tomorrow.

Great to hear that. Thanks for your effort. I will try to test your v3 
when I have received the new hardware and got it up and running.

> 
> I also started work on HDCP support for this driver and hope to send
> soon a patch for that.
> 
> Best regards,
> Bogdan
> 
> On Wed, 2019-11-27 at 11:52 +0000, Schrempf Frieder wrote:
>> [External]
>>
>> Hi Bogdan,
>>
>> On 21.08.19 07:34, Togorean, Bogdan wrote:
>>> On Tue, 2019-08-20 at 10:53 +0200, Daniel Vetter wrote:
>>>> [External]
>>>>
>>>> On Mon, Aug 19, 2019 at 12:46:16PM +0200, Sam Ravnborg wrote:
>>>>> Hi Bogdan.
>>>>>
>>>>>>>>    		adv7533_detach_dsi(adv7511);
>>>>>>>>    	i2c_unregister_device(adv7511->i2c_cec);
>>>>>>>>    	if (adv7511->cec_clk)
>>>>>>>> @@ -1266,8 +1278,9 @@ static const struct i2c_device_id
>>>>>>>> adv7511_i2c_ids[] = {
>>>>>>>>    	{ "adv7511", ADV7511 },
>>>>>>>>    	{ "adv7511w", ADV7511 },
>>>>>>>>    	{ "adv7513", ADV7511 },
>>>>>>>> -#ifdef CONFIG_DRM_I2C_ADV7533
>>>>>>>> +#ifdef CONFIG_DRM_I2C_ADV753x
>>>>>>>>    	{ "adv7533", ADV7533 },
>>>>>>>> +	{ "adv7535", ADV7535 },
>>>>>>>>    #endif
>>>>>>>
>>>>>>> This ifdef may not be needed??
>>>>>>> If we did not get this type we will not look it up.
>>>>>> But if we have defined in DT adv7533/5 device but
>>>>>> CONFIG_DRM_I2C_ADV753x not selected probe will fail with
>>>>>> ENODEV.
>>>>>> That
>>>>>> would be ok?
>>>>>
>>>>> What do we gain from this complexity in the end.
>>>>> Why not let the driver always support all variants.
>>>>>
>>>>> If this result in a simpler driver, and less choices in Kconfig
>>>>> then it is a win-win.
>>>>
>>>> Yeah in general we don't Kconfig within drivers in drm to disable
>>>> specific
>>>> code-paths. It's not worth the pain.
>>   >
>>> Ack,
>>> Thank you for clarification. Will remove in V3.
>>
>> Are you still working on this? Do you plan to send a v3?
>> I will soon lay my hands on a board with the ADV7535 and would like
>> to
>> see this merged.
>> Also for patch 1/2, it seems you already have a R-b for v1 from
>> Laurent,
>> but you didn't carry the tag to v2.
>>
>> Thanks,
>> Frieder