linux-kernel - RE: [PATCH RESEND 2/2] scsi: ufs: Update L4 attributes on manual hibern8 exit in Cadence UFS.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Nov 2019 15:18:37 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Alim Akhtar <alim.akhtar@...sung.com>,
        'Vignesh Raghavendra' <vigneshr@...com>,
        'Alim Akhtar' <alim.akhtar@...il.com>,
        'sheebab' <sheebab@...ence.com>
CC:     'Pedro Sousa' <pedrom.sousa@...opsys.com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        'Stanley Chu' <stanley.chu@...iatek.com>,
        "'Bean Huo (beanhuo)'" <beanhuo@...ron.com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        'open list' <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "rafalc@...ence.com" <rafalc@...ence.com>,
        "mparab@...ence.com" <mparab@...ence.com>
Subject: RE: [PATCH RESEND 2/2] scsi: ufs: Update L4 attributes on manual
 hibern8 exit in Cadence UFS.

 

> >
> >
> > On 20/11/19 9:50 PM, Alim Akhtar wrote:
> > > Hi Sheebab
> > >
> > > On Tue, Nov 19, 2019 at 12:38 PM sheebab <sheebab@...ence.com>
> wrote:
> > >>
> > >> Backup L4 attributes duirng manual hibern8 entry and restore the L4
> > >> attributes on manual hibern8 exit as per JESD220C.
> > >>
> > > Can you point me to the relevant section on the spec?
> > >
> >
> > Per JESD 220C 9.4 UniPro/UFS Control Interface (Control Plane):
> >
> > "NOTE After exit from Hibernate all UniPro Transport Layer attributes
> > (including
> > L4 T_PeerDeviceID,
> >
> > L4 T_PeerCPortID, L4 T_ConnectionState, etc.) will be reset to their reset
> values.
> > All required attributes
> >
> > must be restored properly on both ends before communication can resume."
> >
> > But its not clear whether SW needs to restore these attributes or
> > hardware
> >
> Thanks Vignesh for pointing out the spec section, yes it is not clear, one way to
> confirm this is just by read L4 attributes before And after hinern8 entry/exit.
> (at least in the current platform it is not being done) AFA this patch is concerns,
> this looks ok to me.
> @ Avri , any thought on this?
Yes, it looks fine.

Thanks,
Avri