linux-kernel - Re: [PATCH] perf jit: move test functionality in to a test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191127160558.GM22719@kernel.org>
Date:   Wed, 27 Nov 2019 13:05:58 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Song Liu <songliubraving@...com>, Leo Yan <leo.yan@...aro.org>,
        Michael Petlan <mpetlan@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf jit: move test functionality in to a test

Em Wed, Nov 27, 2019 at 12:23:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 26, 2019 at 03:59:13PM -0800, Ian Rogers escreveu:
> > Adds a test for minimal jit_write_elf functionality.
> 
> Thanks, tested and applied.

Had to apply this to have it built in systems where HAVE_JITDUMP isn't
defined:

diff --git a/tools/perf/tests/genelf.c b/tools/perf/tests/genelf.c
index d392e9300881..28dfd17a6b9f 100644
--- a/tools/perf/tests/genelf.c
+++ b/tools/perf/tests/genelf.c
@@ -17,16 +17,15 @@
 
 #define TEMPL "/tmp/perf-test-XXXXXX"
 
-static unsigned char x86_code[] = {
-	0xBB, 0x2A, 0x00, 0x00, 0x00, /* movl $42, %ebx */
-	0xB8, 0x01, 0x00, 0x00, 0x00, /* movl $1, %eax */
-	0xCD, 0x80            /* int $0x80 */
-};
-
 int test__jit_write_elf(struct test *test __maybe_unused,
 			int subtest __maybe_unused)
 {
 #ifdef HAVE_JITDUMP
+	static unsigned char x86_code[] = {
+		0xBB, 0x2A, 0x00, 0x00, 0x00, /* movl $42, %ebx */
+		0xB8, 0x01, 0x00, 0x00, 0x00, /* movl $1, %eax */
+		0xCD, 0x80            /* int $0x80 */
+	};
 	char path[PATH_MAX];
 	int fd, ret;
 
@@ -48,6 +47,6 @@ int test__jit_write_elf(struct test *test __maybe_unused,
 
 	return ret ? TEST_FAIL : 0;
 #else
-	return TEST_SKIPPED;
+	return TEST_SKIP;
 #endif
 }