linux-kernel - Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init()

Open Source and information security mailing list archives

Message-ID: <CA+M3ks43CrCqXiQzs=Y2hd6_Z7TK36h98tGHSOGi3BPoWMX9WQ@mail.gmail.com>
Date:   Wed, 27 Nov 2019 17:30:54 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Mihail Atanassov <Mihail.Atanassov@....com>,
        David Airlie <airlied@...ux.ie>, nd <nd@....com>,
        Vincent Abriou <vincent.abriou@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init()

Le mer. 27 nov. 2019 à 17:19, Sam Ravnborg <sam@...nborg.org> a écrit :
>
> Hi Mihail.
>
> > >
> > > I can see from grepping that bridge.driver_private is used
> > > in a couple of other files in sti/
> > >
> > > Like sti_hdmi.c:
> > >         bridge->driver_private = hdmi;
> > >         bridge->funcs = &sti_hdmi_bridge_funcs;
> > >         drm_bridge_attach(encoder, bridge, NULL);
> > >
> > >
> > > I wonder if a drm_bridge_init() should be added there.
> > > I did not look closely - but it looked suspisiously.
> >
> > My goal with drm_bridge_init() was to get devlinks sorted out for
> > cross-module uses of a drm_bridge (via of_drm_find_bridge()), so I only
> > considered locations where drm_bridge_add/remove() were used.
> >
> > Would you be okay with a promise to push a cleanup of this one and the
> > one in sti_hda.c after patch 1/30 lands in some form? I'd rather not
> > make this series much longer, it's already pushing it at 30 :).
>
> Absolutely - my drive-by comment was more out of concern if this
> was missing. A clean-up later souns good.

Or you can just do the changes for sti_hdmi and sti_hda in this patch too.

Benjamin

>
>         Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives