linux-kernel - Re: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1574873298.3.0@crapouillou.net>
Date:   Wed, 27 Nov 2019 17:48:18 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Zhou Yanjie <zhouyanjie@...o.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        paul.burton@...s.com, paulburton@...nel.org, jhogan@...nel.org,
        mripard@...nel.org, shawnguo@...nel.org, mark.rutland@....com,
        syq@...ian.org, ralf@...ux-mips.org, heiko@...ech.de,
        icenowy@...c.io, laurent.pinchart@...asonboard.com,
        krzk@...nel.org, geert+renesas@...der.be,
        prasannatsmkumar@...il.com, sernia.zhou@...mail.com,
        zhenwenjin@...il.com, 772753199@...com
Subject: Re: [PATCH v4 5/6] MIPS: X1000: Add pdma controller DT node.

Hi Zhou,


Le mer., nov. 27, 2019 at 01:06, Zhou Yanjie <zhouyanjie@...o.com> a 
écrit :
> Add the appropriate DT node to probe the pdma controller driver
> using the devicetree.
> 
> Signed-off-by: Zhou Yanjie <zhouyanjie@...o.com>
> ---
> 
> Notes:
>     v4:
>     New patch.
> 
>  arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi 
> b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 9e55edd..edfa70d 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -1,5 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include <dt-bindings/clock/x1000-cgu.h>
> +#include <dt-bindings/dma/x1000-dma.h>

You're not using any macro from that include file, so there's no need 
to have it here.

Cheers,
-Paul


> 
>  / {
>  	#address-cells = <1>;
> @@ -173,4 +174,16 @@
> 
>  		status = "disabled";
>  	};
> +
> +	pdma: dma-controller@...20000 {
> +		compatible = "ingenic,x1000-dma";
> +		reg = <0x13420000 0x400
> +			   0x13421000 0x40>;
> +		#dma-cells = <2>;
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <10>;
> +
> +		clocks = <&cgu X1000_CLK_PDMA>;
> +	};
>  };
> --
> 2.7.4
> 
>