linux-kernel - Re: [PATCH 1/2] crypto: atmel-tdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <642709fe-8cee-4c08-9a4a-05aa47d43c08@microchip.com>
Date:   Wed, 27 Nov 2019 16:56:37 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <herbert@...dor.apana.org.au>
CC:     <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] crypto: atmel-tdes - Set the IV after {en,de}crypt



On 11/15/19 3:49 PM, Tudor Ambarus - M18064 wrote:
>  static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
>  {
>  	struct skcipher_request *req = dd->req;
> @@ -580,6 +605,8 @@ static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
>  
>  	dd->flags &= ~TDES_FLAGS_BUSY;
>  
> +	atmel_tdes_set_iv_as_last_ciphertext_block(dd);

ECB mode does not use an IV, I should probably exclude the update of IV for the
ECB mode. v2 will follow.

> +
>  	req->base.complete(&req->base, err);
>  }