linux-kernel - Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191127173547.ch3pcv3lxgdcrfnu@gilmour.lan>
Date:   Wed, 27 Nov 2019 18:35:47 +0100
From:   Maxime Ripard <mripard@...nel.org>
To:     Vasily Khoruzhick <anarsoul@...il.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chen-Yu Tsai <wens@...e.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for
 H6/H5/H3/A64/A83T/R40

On Wed, Nov 27, 2019 at 12:14:19PM +0100, Ondřej Jirman wrote:
> > +	/*
> > +	 * Avoid entering the interrupt handler, the thermal device is not
> > +	 * registered yet, we deffer the registration of the interrupt to
> > +	 * the end.
> > +	 */
> > +	ret = devm_request_threaded_irq(dev, irq, NULL,
> > +					sun8i_irq_thread,
> > +					IRQF_ONESHOT, "ths", tmdev);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return ret;
>
> I guess just return devm_request_threaded_irq(... ^

This is harder to extend though, so I'd keep the current construct
(with a return 0 though).

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)