linux-kernel - Re: [PATCH v2] KVM: SVM: Fix "error" isn't initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b0b053a-66cd-c712-4bba-732084075e97@amd.com>
Date:   Wed, 27 Nov 2019 12:11:54 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Haiwei Li <lihaiwei.kernel@...il.com>,
        "x86@...nel.org" <x86@...nel.org>, kvm@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-crypto@...r.kernel.org
Cc:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        gary.hook@....com, herbert@...dor.apana.org.au, davem@...emloft.net
Subject: Re: [PATCH v2] KVM: SVM: Fix "error" isn't initialized

On 11/27/19 1:23 AM, Haiwei Li wrote:
>  From e7f9c786e43ef4f890b8a01f15f8f00786f4b14a Mon Sep 17 00:00:00 2001
> From: Haiwei Li <lihaiwei@...cent.com>
> Date: Wed, 27 Nov 2019 15:00:49 +0800
> Subject: [PATCH v2] fix: 'error' is not initialized
> 
> There are a bunch of error paths were "error" isn't initialized.

Please provide a better patch commit message and just fix the actual
problem, which is error is uninitialized in sev_flush_asids(). Please
just initialize error to zero.

Thanks,
Tom

> 
> Signed-off-by: Haiwei Li <lihaiwei@...cent.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>   arch/x86/kvm/svm.c           | 3 ++-
>   drivers/crypto/ccp/psp-dev.c | 2 ++
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 362e874..9eef6fc 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -6308,7 +6308,8 @@ static int sev_flush_asids(void)
>       up_write(&sev_deactivate_lock);
> 
>       if (ret)
> -        pr_err("SEV: DF_FLUSH failed, ret=%d, error=%#x\n", ret, error);
> +        pr_err("SEV: DF_FLUSH failed, ret=%d. PSP returned error=%#x\n",
> +               ret, error);
> 
>       return ret;
>   }
> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
> index 39fdd06..c486c24 100644
> --- a/drivers/crypto/ccp/psp-dev.c
> +++ b/drivers/crypto/ccp/psp-dev.c
> @@ -155,6 +155,8 @@ static int __sev_do_cmd_locked(int cmd, void *data, 
> int *psp_ret)
>       unsigned int phys_lsb, phys_msb;
>       unsigned int reg, ret = 0;
> 
> +    *psp_ret = -1;
> +
>       if (!psp)
>           return -ENODEV;
> 
> -- 
> 1.8.3.1