linux-kernel - Re: [PATCH] net/mlx5e: Fix build error without IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191127.112635.1621097212312385906.davem@davemloft.net>
Date:   Wed, 27 Nov 2019 11:26:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     saeedm@...lanox.com, leon@...nel.org, eli@...lanox.com,
        roid@...lanox.com, elibr@...lanox.com, kliteyn@...lanox.com,
        ozsh@...lanox.com, pablo@...filter.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix build error without IPV6

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 27 Nov 2019 21:27:00 +0800

> If IPV6 is not set and CONFIG_MLX5_ESWITCH is y,
> building fails:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:322:5: error: redefinition of mlx5e_tc_tun_create_header_ipv6
>  int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:7:0:
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:67:1: note: previous definition of mlx5e_tc_tun_create_header_ipv6 was here
>  mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Use #ifdef to guard this, also move mlx5e_route_lookup_ipv6
> to cleanup unused warning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: e689e998e102 ("net/mlx5e: TC, Stub out ipv6 tun create header function")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Saeed et al., how do you want to handle this?

Thanks.