linux-kernel - RE: [EXT] Re: [PATCH] i2c: imx: Defer probing if EDMA not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB44315FD37E81C7EE6903D49FED470@VI1PR04MB4431.eurprd04.prod.outlook.com>
Date:   Thu, 28 Nov 2019 02:45:52 +0000
From:   Peng Ma <peng.ma@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH] i2c: imx: Defer probing if EDMA not available



>-----Original Message-----
>From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>Sent: 2019年11月27日 15:27
>To: Peng Ma <peng.ma@....com>
>Cc: linux@...pel-privat.de; kernel@...gutronix.de; shawnguo@...nel.org;
>s.hauer@...gutronix.de; linux-kernel@...r.kernel.org; dl-linux-imx
><linux-imx@....com>; festevam@...il.com;
>linux-arm-kernel@...ts.infradead.org; linux-i2c@...r.kernel.org
>Subject: [EXT] Re: [PATCH] i2c: imx: Defer probing if EDMA not available
>
>Caution: EXT Email
>
>Hello,
>
>On Wed, Nov 27, 2019 at 07:12:09AM +0000, Peng Ma wrote:
>> EDMA may be not available or defered due to dependencies on other
>> modules, If these scenarios is encountered, we should defer probing.
>
>I'd write:
>
>        i2c: imx: Defer probing if requesting DMA yields EPROBE_DEFER
>
>        DMA might not be available yet when the i2c device probes.
>        Properly handle EPROBE_DEFER on dma channel allocation by
>        passing on this error.
>
>It would be nice to point out where/how this failed for you.
>
>Other than that this looks reasonable.
>
Hi, Uwe,

Thanks very much for your comments, That looks good.

Best Regards,
Peng
>Best regards
>Uwe
>
>--
>Pengutronix e.K.                           | Uwe Kleine-König
>|
>Industrial Linux Solutions                 |
>https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
>engutronix.de%2F&amp;data=02%7C01%7Cpeng.ma%40nxp.com%7C426ec4f
>5f1f14751022f08d7730b4043%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
>%7C1%7C637104364470568722&amp;sdata=JjD2ovy4oxZseUEUwNERASBJCk
>0oMLSplb8qRTkhaTE%3D&amp;reserved=0 |