linux-kernel - Re: [PATCH] MIPS: Fix boot on Fuloong2 systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1F64121F-0A46-41C2-ABE0-917A1A968A3E@flygoat.com>
Date:   Thu, 28 Nov 2019 08:42:28 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Paul Burton <paulburton@...nel.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Fix boot on Fuloong2 systems



于 2019年11月27日 GMT+08:00 下午11:26:12, Guenter Roeck <linux@...ck-us.net> 写到:
>Commit 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES") changed
>Kconfig symbols as follows:
>	CPU_LOONGSON2 to CPU_LOONGSON2EF
>	CPU_LOONGSON3 to CPU_LOONGSON64
>	SYS_HAS_CPU_LOONGSON3 to SYS_HAS_CPU_LOONGSON64
>
>It did not touch SYS_HAS_CPU_LOONGSON2E or SYS_HAS_CPU_LOONGSON2F.
>However, the patch changed a conditional from
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2E) || \
>     defined(CONFIG_SYS_HAS_CPU_LOONGSON2F)
>
>to
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2EF)
>
>SYS_HAS_CPU_LOONGSON2EF does not exist, resulting in boot failures
>with the qemu fulong2e emulation. Revert to the original code.
>
>Fixes: 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES")
>Cc: Jiaxun Yang <jiaxun.yang@...goat.com>
>Signed-off-by: Guenter Roeck <linux@...ck-us.net>
Acked-by: Jiaxun Yang <jiaxun.yang@...goat.com>

Apologies for the mistake. I ran some tests before sending the
patch but probably get this missed due to
difference between my local tree and next tree.

Thanks for catching that!
>---

-- 
Jiaxun Yang