linux-kernel - Re: [PATCH v2] mm: fix comments related to node reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <688fe7f3-f94c-6e67-9c35-0d6cf1096e02@arm.com>
Date:   Thu, 28 Nov 2019 10:57:23 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Hao Lee <haolee.swjtu@...il.com>, akpm@...ux-foundation.org
Cc:     mgorman@...e.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: fix comments related to node reclaim



On 11/26/2019 07:43 PM, Hao Lee wrote:
> As zone reclaim has been replaced by node reclaim, this patch fixes related
> comments.
> 
> Signed-off-by: Hao Lee <haolee.swjtu@...il.com>
> ---
>  include/linux/mmzone.h      | 2 +-
>  include/uapi/linux/sysctl.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 9e47289a4511..7e3208f4f5bc 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -747,7 +747,7 @@ typedef struct pglist_data {
>  
>  #ifdef CONFIG_NUMA
>  	/*
> -	 * zone reclaim becomes active if more unmapped pages exist.
> +	 * node reclaim becomes active if more unmapped pages exist.
>  	 */
>  	unsigned long		min_unmapped_pages;
>  	unsigned long		min_slab_pages;
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 87aa2a6d9125..27c1ed2822e6 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -195,7 +195,7 @@ enum
>  	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
>  	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
>  	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
> -	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
> +	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
>  };

This looks good to me but wondering if this sort of change could qualify
for a stand alone patch or should be carried along with other functional
changes. Will leave it upto others to decide.

>  
>  
>