linux-kernel - RE: [PATCH 2/3] net: macb: add support for C45 MDIO read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR07MB65147759BC70B370E6834451D3470@BY5PR07MB6514.namprd07.prod.outlook.com>
Date:   Thu, 28 Nov 2019 08:29:03 +0000
From:   Milind Parab <mparab@...ence.com>
To:     Andrew Lunn <andrew@...n.ch>,
        "Nicolas.Ferre@...rochip.com" <Nicolas.Ferre@...rochip.com>
CC:     "antoine.tenart@...tlin.com" <antoine.tenart@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dhananjay Vilasrao Kangude <dkangude@...ence.com>,
        Parshuram Raju Thombare <pthombar@...ence.com>,
        "rmk+kernel@....linux.org.uk" <rmk+kernel@....linux.org.uk>
Subject: RE: [PATCH 2/3] net: macb: add support for C45 MDIO read/write



>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Thursday, November 28, 2019 12:21 AM
>To: Nicolas.Ferre@...rochip.com
>Cc: Milind Parab <mparab@...ence.com>; antoine.tenart@...tlin.com;
>davem@...emloft.net; netdev@...r.kernel.org; f.fainelli@...il.com;
>hkallweit1@...il.com; linux-kernel@...r.kernel.org; Dhananjay Vilasrao
>Kangude <dkangude@...ence.com>; Parshuram Raju Thombare
><pthombar@...ence.com>; rmk+kernel@....linux.org.uk
>Subject: Re: [PATCH 2/3] net: macb: add support for C45 MDIO read/write
>
>EXTERNAL MAIL
>
>
>On Wed, Nov 27, 2019 at 06:31:54PM +0000, Nicolas.Ferre@...rochip.com
>wrote:
>> On 26/11/2019 at 15:37, Andrew Lunn wrote:
>> > On Tue, Nov 26, 2019 at 09:09:49AM +0000, Milind Parab wrote:
>> >> This patch modify MDIO read/write functions to support
>> >> communication with C45 PHY.
>> >
>> > I think i've asked this before, at least once, but you have not
>> > added it to the commit messages. Do all generations of the macb support
>C45?
>>
>> For what I can tell from the different IP revisions that we
>> implemented throughout the years in Atmel then Microchip products
>> (back to
>> at91rm9200 and at91sam9263), it seems yes.
>>
>> The "PHY Maintenance Register" "MACB_MAN_*" was always present with
>> the same bits 32-28 layout (with somehow different names).
>>
>> But definitively we would need to hear that from Cadence itself which
>> would be far better.
>
>Hi Nicolas
>
>Thanks, that is useful.
>
>I'm just trying to avoid backward compatibility issues, somebody issues a C45
>request on old silicon and it all goes horribly wrong.

This patch doesn't affect current C22 operation of the driver. 
However if a user selects C45 on incompatible MAC (there are old MAC, prior to Release1p10, released 10th April 2003) MDIO operations may fails.
Adding check will cover this corner case.

We will add this check in v2 of patch set.
>
>       Andrew