linux-kernel - [PATCH] irqchip/stm32: Fix "WARNING: invalid free of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1574931880-168682-1-git-send-email-huangdaode@hisilicon.com>
Date:   Thu, 28 Nov 2019 17:04:40 +0800
From:   Daode Huang <huangdaode@...ilicon.com>
To:     <tglx@...utronix.de>, <jason@...edaemon.net>, <maz@...nel.org>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...com>,
        <fabien.dessenne@...com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: [PATCH] irqchip/stm32: Fix "WARNING: invalid free of devm_ allocated

Since devm_ allocated data can be automaitcally released, it's no
need to free it apparently, just remove it.

Fixes: cfbf9e497094 ("irqchip/stm32: Use a platform driver for
stm32mp1-exti device")
Signed-off-by: Daode Huang <huangdaode@...ilicon.com>
---
 drivers/irqchip/irq-stm32-exti.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index e00f2fa..46ec0af 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -779,8 +779,6 @@ static int __init stm32_exti_init(const struct stm32_exti_drv_data *drv_data,
 	irq_domain_remove(domain);
 out_unmap:
 	iounmap(host_data->base);
-	kfree(host_data->chips_data);
-	kfree(host_data);
 	return ret;
 }
 
-- 
2.8.1