linux-kernel - Re: [PATCH] genirq: show irq name in non-oneshot error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e698b81f-54c3-6d47-8a4b-80c15b58aaad@lucaceresoli.net>
Date:   Thu, 28 Nov 2019 10:08:54 +0100
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] genirq: show irq name in non-oneshot error message

Hi,

On 05/11/19 15:08, Luca Ceresoli wrote:
> Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the
> error message does not include the IRQ line name, which makes it harder to
> find the offending driver.
> 
> Print the IRQ line name to clarify where the error comes from. Use the same
> format as other pr_err() above in the same function.
> 
> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> ---
>  kernel/irq/manage.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 1753486b440c..b6c53ab053d2 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>  		 * has. The type flags are unreliable as the
>  		 * underlying chip implementation can override them.
>  		 */
> -		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
> -		       irq);
> +		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
> +		       new->name, irq);

Gently pinging about this trivial patch.

Should I send it elsewhere than where get_maintainer.pl suggests?

Thanks,
-- 
Luca