linux-kernel - Re: [PATCH] usb: gadget: f_ncm: fix wrong usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR12MB3389A88286B9A8348596F947AC470@MN2PR12MB3389.namprd12.prod.outlook.com>
Date:   Thu, 28 Nov 2019 09:21:08 +0000
From:   Henry Lin <henryl@...dia.com>
To:     Peter Chen <peter.chen@....com>
CC:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Romain Izard <romain.izard.pro@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        EJ Hsu <ejh@...dia.com>
Subject: Re: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep

>> >Does your UDC driver call composite_disconnect when disconnect from the host?
>> >It should set all desc to NULL at related function ->disable.
>>
>> For ECM case, if ecm_set_alt() gets called with alt == 0, in_ep->desc and out_ep-
>> >desc will be set up. But these two ep will not be enabled as gether_connect() is not
>> executed. During disconnect from the host, ecm_disable() gets called with ep
>> disabled. In this case, gether_disconnect() will not get called to set desc to NULL.

>Would you please share your test case? I use Linux host, and the host will always set alt for 1,
>and doesn't have this issue.
Using Windows host (without any proprietary NCM/ECM driver installed) can reproduce set alt
to 0. We just used Win10 to confirm this.