linux-kernel - Re: [PATCH] checkpatch: Look for Kconfig indentation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab3309596fac1c5a0cb4e0abed0cf1ee7ac13a3d.camel@perches.com>
Date:   Thu, 28 Nov 2019 01:34:47 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: [PATCH] checkpatch: Look for Kconfig indentation errors

On Thu, 2019-11-28 at 11:29 +0200, Jani Nikula wrote:
> On Thu, 28 Nov 2019, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > Kconfig should be indented with one tab for first level and tab+2 spaces
> > for second level.  There are many mixups of this so add a checkpatch
> > rule.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> I agree unifying the indentation is nice, and without something like
> this it'll start bitrotting before Krzysztof's done fixing them all... I
> think there's been quite a few fixes merged lately.
> 
> I approve of the idea, but I'm clueless about the implementation.

I think that a grammar, or a least an array of words
that are supposed to start on a tab should be used here.