linux-kernel - Re: [PATCH 4/4] checkpatch: Drop pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34b6c8637bfe636b2b4880e536a190627bb1ee91.camel@perches.com>
Date:   Wed, 27 Nov 2019 17:05:08 -0800
From:   Joe Perches <joe@...ches.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>, pmladek@...e.com,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     gregkh@...uxfoundation.org, tj@...nel.org, arnd@...db.de,
        sergey.senozhatsky@...il.com, rostedt@...dmis.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH 4/4] checkpatch: Drop pr_warning check

On Thu, 2019-11-28 at 08:47 +0800, Kefeng Wang wrote:
> All pr_warning are removed from kernel, let's cleanup pr_warning
> check in checkpatch.
> 
> Cc: Andy Whitcroft <apw@...onical.com>
> Cc: Joe Perches <joe@...ches.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Assuming the other bits go in:

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 64890be3c8fd..447c0050eec0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4113,15 +4113,6 @@ sub process {
>  			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
>  		}
>  
> -		if ($line =~ /\bpr_warning\s*\(/) {
> -			if (WARN("PREFER_PR_LEVEL",
> -				 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
> -			    $fix) {
> -				$fixed[$fixlinenr] =~
> -				    s/\bpr_warning\b/pr_warn/;
> -			}
> -		}
> -
>  		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
>  			my $orig = $1;
>  			my $level = lc($orig);