linux-kernel - Re: [PATCH v4] tpm: Add tpm_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191128010826.w4ixlix3s3ovta3m@cantor>
Date:   Wed, 27 Nov 2019 18:08:26 -0700
From:   Jerry Snitselaar <jsnitsel@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-integrity@...r.kernel.org
Subject: Re: [PATCH v4] tpm: Add tpm_version_major sysfs file

On Wed Oct 30 19, Jerry Snitselaar wrote:
>Easily determining what TCG version a tpm device implements
>has been a pain point for userspace for a long time, so
>add a sysfs file to report the TCG major version of a tpm device.
>
>Also add an entry to Documentation/ABI/stable/sysfs-class-tpm
>describing the new file.
>
>Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>Cc: Mimi Zohar <zohar@...ux.ibm.com>
>Cc: Peter Huewe <peterhuewe@....de>
>Cc: Jason Gunthorpe <jgg@...pe.ca>
>Cc: linux-integrity@...r.kernel.org
>Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>
>---
>v4: - Change file name to tpm_version_major
>    - Actually display just the major version.
>    - change structs to tpm1_* & tpm2_*
>      instead of tpm12_* tpm20_*.
>v3: - Change file name to version_major.
>v2: - Fix TCG usage in commit message.
>    - Add entry to sysfs-class-tpm in Documentation/ABI/stable
>
> Documentation/ABI/stable/sysfs-class-tpm | 11 ++++++++
> drivers/char/tpm/tpm-sysfs.c             | 34 +++++++++++++++++++-----
> 2 files changed, 38 insertions(+), 7 deletions(-)
>

Anyone else have feedback?