linux-kernel - Re: [PATCH v2] KVM: vgic: Use wrapper function to lock/unlock all vcpus in kvm_vgic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <49f3dec1fa65498c84d0344e0ea629ce@huawei.com>
Date:   Thu, 28 Nov 2019 11:16:28 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Steven Price <steven.price@....com>,
        "maz@...nel.org" <maz@...nel.org>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "james.morse@....com" <james.morse@....com>,
        "julien.thierry.kdev@...il.com" <julien.thierry.kdev@...il.com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "christoffer.dall@....com" <christoffer.dall@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "will@...nel.org" <will@...nel.org>,
        "andre.przywara@....com" <andre.przywara@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] KVM: vgic: Use wrapper function to lock/unlock all
 vcpus in kvm_vgic_create()

Steven Price wrote:
>>   
>>   	if (irqchip_in_kernel(kvm))
>> @@ -92,11 +92,8 @@ int kvm_vgic_create(struct kvm *kvm, u32 type)
>Extra context:
>
>	/*
>	 * Any time a vcpu is run, vcpu_load is called which tries to grab the
>	 * vcpu->mutex.  By grabbing the vcpu->mutex of all VCPUs we ensure
>>   	 * that no other VCPUs are run while we create the vgic.
>>   	 */
>
>That comment no longer makes sense here - there's a very similar one already in lock_all_vcpus(). With that removed:
>
>Reviewed-by: Steven Price <steven.price@....com>
>
Many thanks for your review. That comment no longer makes sense as you figured out. I will
remove that. Thanks again.

>>   	ret = -EBUSY;
>> -	kvm_for_each_vcpu(i, vcpu, kvm) {
>> -		if (!mutex_trylock(&vcpu->mutex))
>> -			goto out_unlock;
>> -		vcpu_lock_idx = i;