linux-kernel - Re: [PATCH] clk: at91: fix possible deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191128135822.GA6522@qmqm.qmqm.pl>
Date:   Thu, 28 Nov 2019 14:58:22 +0100
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: at91: fix possible deadlock

On Thu, Nov 28, 2019 at 11:25:31AM +0100, Alexandre Belloni wrote:
> Lockdep warns about a possible circular locking dependency because using
> syscon_node_to_regmap() will make the created regmap get and enable the
> first clock it can parse from the device tree. This clock is not needed to
> access the registers and should not be enabled at that time.
> 
> Use the recently introduced device_node_to_regmap to solve that as it looks
> up the regmap in the same list but doesn't care about the clocks.
> 
> Reported-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
[...]

Tested-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Thanks! Can you push this to stable?

Best Regards,
Michał Mirosław