linux-kernel - Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Nov 2019 16:31:31 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Qian Cai <cai@....pw>
Cc:     Michal Hocko <mhocko@...nel.org>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in
 find_(smallest|biggest)_section_pfn

On 28.11.19 16:29, Qian Cai wrote:
> 
> 
>> On Nov 28, 2019, at 9:52 AM, David Hildenbrand <david@...hat.com> wrote:
>>
>> I also agree that it should not be used for basic functional/compile
>> tests (I said "It is a way of giving patches *more* testing."). It
>> should not be the only place to test stuff (especially to let somebody
>> else do it).
>>
>> However, sometimes we really have to get additional test coverage via
>> linux-next, especially for weird archs/configurations/setups.
>>
>> ... and if we don't have enough reviewers, it's really hard to get stuff
>> upstream.
>>
>> I wish MM patches would get reviewed more thoroughly.
>>
>> (If we all make a wish, maybe Santa Clause will listen ;) )
> 
> What I don’t understand is that we have an policy prohibiting code churn like code optimization in cold path, but allow those micro cleanup of code. Those cleanup also tend to be unregulated and is subject to personal tastes (for example, your CS teachers may have a different taste from mine). I can understand developers want to have fun, but perhaps there are other playground areas that worth taking more risk? 
> 

I said all I had to say about this topic, especially also why cleanups
and refactorings are important. No, you won't change the way I (and most
other people here) work, sorry.

-- 
Thanks,

David / dhildenb