linux-kernel - Re: [PATCH v3 1/4] s390/unwind: drop unnecessary code around calling ftrace_graph_ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <your-ad-here.call-01574959907-ext-0700@work.hours>
Date:   Thu, 28 Nov 2019 17:51:47 +0100
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     heiko.carstens@...ibm.com, borntraeger@...ibm.com,
        jpoimboe@...hat.com, joe.lawrence@...hat.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        jikos@...nel.org, pmladek@...e.com, nstange@...e.de,
        live-patching@...r.kernel.org
Subject: Re: [PATCH v3 1/4] s390/unwind: drop unnecessary code around calling
 ftrace_graph_ret_addr()

On Wed, Nov 06, 2019 at 10:55:58AM +0100, Miroslav Benes wrote:
> The current code around calling ftrace_graph_ret_addr() is ifdeffed and
> also tests if ftrace redirection is present on stack.
> ftrace_graph_ret_addr() however performs the test internally and there
> is a version for !CONFIG_FUNCTION_GRAPH_TRACER as well. The unnecessary
> code can thus be dropped.
> 
> Signed-off-by: Miroslav Benes <mbenes@...e.cz>
> ---
>  arch/s390/kernel/unwind_bc.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

This patch has been picked up from v2 already. It's in Linus tree.