linux-kernel - Re: [PATCH] MIPS: Kconfig: Use correct form for 'depends on'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAdtpL5bg=B6iKWT-QjnWzpW7hxU25PN_xtYq_1jX=2jbGfr=w@mail.gmail.com>
Date:   Thu, 28 Nov 2019 21:11:09 +0100
From:   Philippe Mathieu-Daudé <f4bug@...at.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Kconfig: Use correct form for 'depends on'

On Thu, Nov 28, 2019 at 6:23 PM Joe Perches <joe@...ches.com> wrote:
>
> Remove the CONFIG_ prefix from "depends on" as it makes the selection
> not possible.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/platform/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index f4d0a86..5e77b0 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -18,7 +18,7 @@ if MIPS_PLATFORM_DEVICES
>
>  config CPU_HWMON
>         tristate "Loongson-3 CPU HWMon Driver"
> -       depends on CONFIG_MACH_LOONGSON64
> +       depends on MACH_LOONGSON64
>         select HWMON
>         default y
>         help
>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@...at.org>