linux-kernel - Re: [PATCH] fsi: fix bogos error returns from cfam_read and cfam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a709068c-9375-4921-a87f-c5f3a1f63cf2@www.fastmail.com>
Date:   Fri, 29 Nov 2019 09:02:39 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Colin King" <colin.king@...onical.com>,
        "Jeremy Kerr" <jk@...abs.org>, "Joel Stanley" <joel@....id.au>,
        "Alistair Popple" <alistair@...ple.id.au>,
        "Eddie James" <eajames@...ux.ibm.com>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        linux-fsi@...ts.ozlabs.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi: fix bogos error returns from cfam_read and cfam_write



On Sat, 23 Nov 2019, at 10:01, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> In the case where errors occur in functions cfam_read and cfam_write
> the error return code in rc is not returned and a bogus non-error
> count size is returned instead. Fix this by returning the correct
> error code when an error occurs or the count size if the functions
> worked correctly.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: d1dcd6782576 ("fsi: Add cfam char devices")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Andrew Jeffery <andrew@...id.au>