linux-kernel - Re: [PATCH v1] net: WireGuard secure network tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9p8cxUtZhegkNrCF+GgREKQA=5LQ_km35qopC-2SKtJaw@mail.gmail.com>
Date:   Fri, 29 Nov 2019 12:47:37 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     David Miller <davem@...emloft.net>
Cc:     Netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH v1] net: WireGuard secure network tunnel

On Fri, Nov 29, 2019 at 7:27 AM David Miller <davem@...emloft.net> wrote:
>
> From: "Jason A. Donenfeld" <Jason@...c4.com>
> Date: Fri, 29 Nov 2019 04:32:05 +0100
>
> > I'm not a huge fan of doing manual skb surgery either. The annoying
> > thing here is that skb_gso_segment returns a list of skbs that's
> > terminated by the last one's next pointer being NULL. I assume it's this
> > way so that the GSO code doesn't have to pass a head around.
>
> Sorry, I missed that this was processing a GSO list which doesn't use
> double linked list semantics.
>
> So ignore my feedback on this one :-)

Okay, no problem. I'll submit some global tree-wide cleanup patches in
the way of a helper macro sometime after all the wireguard dust
settles, then, and we can assess that separately.