linux-kernel - Re: MIPS: bug: gettimeofday syscall broken on CI20 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Nov 2019 12:51:19 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Maarten ter Huurne <maarten@...ewalker.org>,
        mips-creator-ci20-dev@...glegroups.com,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>, linux-mips@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: MIPS: bug: gettimeofday syscall broken on CI20 board

Hi Vincenzo,

> Am 29.11.2019 um 11:53 schrieb Vincenzo Frascino <vincenzo.frascino@....com>:
> 
> Hi Nikolaus,
> 
> On 11/29/19 8:57 AM, Vincenzo Frascino wrote:
>> On 11/28/19 4:47 PM, H. Nikolaus Schaller wrote:
>>> Well, it does not immediately compile because CONFIG_MIPS_CLOCK_VSYSCALL is not
>>> set and can not be configured by normal means:
>>> 
>>> Error:
>>> 
>>> /Volumes/CaseSensitive/master/lib/vdso/gettimeofday.c: In function '__cvdso_gettimeofday':
>>> /Volumes/CaseSensitive/master/lib/vdso/gettimeofday.c:152:4: error: implicit declaration of function 'gettimeofday_fallback' [-Werror=implicit-function-declaration]
>>>    return gettimeofday_fallback(tv, tz);
>> 
>> Oops, I just realized that I had other changes not committed that's why it does
>> not build for you directly. Sometimes I get so excited for fixing a problem that
>> I forget bits and peaces :) Sorry about that.
>> 
>> I am happy to hear that this sorts out the issue though. I will send out a new
>> series to test.
>> 
> 
> Could you please try the patch in attachment? It should be all this time.

Yes,
applies well, compiles well and works.

So you can add:

Testes-by: H. Nikolaus Schaller <hns@...delico.com> # CI20 with JZ4780

> 
> Thanks!

BR and thanks,
Nikolaus