linux-kernel - Re: [PATCH] drm/qxl: Complete exception handling in qxl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191129122454.2xoi43kaowmqppm5@sirius.home.kraxel.org>
Date:   Fri, 29 Nov 2019 13:24:54 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     dri-devel@...ts.freedesktop.org, spice-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        Anton Vasilyev <vasilyev@...ras.ru>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Dave Airlie <airlied@...hat.com>,
        Kangjie Lu <kjlu@....edu>, Navid Emamdoost <emamd001@....edu>,
        Stephen McCamant <smccaman@....edu>
Subject: Re: [PATCH] drm/qxl: Complete exception handling in qxl_device_init()

On Thu, Nov 07, 2019 at 06:18:14PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 7 Nov 2019 18:05:08 +0100
> 
> A coccicheck run provided information like the following.
> 
> drivers/gpu/drm/qxl/qxl_kms.c:295:1-7: ERROR: missing iounmap;
> ioremap on line 178 and execution via conditional on line 185
> 
> Generated by: scripts/coccinelle/free/iounmap.cocci
> 
> A jump target was specified in an if branch. The corresponding function
> call did not release the desired system resource then.
> Thus use the label “rom_unmap” instead to fix the exception handling
> for this function implementation.
> 
> Fixes: 5043348a4969ae1661c008efe929abd0d76e3792 ("drm: qxl: Fix error handling at qxl_device_init")
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Pushed to drm-misc-next.

thanks,
  Gerd