linux-kernel - Re: [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e785a585-8b71-8a49-285e-2bcb1437500b@citrix.com>
Date:   Fri, 29 Nov 2019 15:09:53 +0000
From:   Andrew Cooper <andrew.cooper3@...rix.com>
To:     Julien Grall <julien@....org>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        <jmorris@...ei.org>, <sashal@...nel.org>,
        <linux-kernel@...r.kernel.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <steve.capper@....com>,
        <linux-arm-kernel@...ts.infradead.org>, <marc.zyngier@....com>,
        <james.morse@....com>, <vladimir.murzin@....com>,
        <mark.rutland@....com>, <tglx@...utronix.de>,
        <gregkh@...uxfoundation.org>, <allison@...utok.net>,
        <info@...ux.net>, <alexios.zavras@...el.com>,
        <sstabellini@...nel.org>, <boris.ostrovsky@...cle.com>,
        <jgross@...e.com>, <stefan@...er.ch>,
        <yamada.masahiro@...ionext.com>, <xen-devel@...ts.xenproject.org>,
        <linux@...linux.org.uk>
Subject: Re: [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for
 privcmd_call

On 29/11/2019 15:05, Julien Grall wrote:
> Hi,
>
> On 27/11/2019 18:44, Pavel Tatashin wrote:
>> diff --git a/arch/arm64/include/asm/xen/hypercall.h
>> b/arch/arm64/include/asm/xen/hypercall.h
>> index 3522cbaed316..1a74fb28607f 100644
>> --- a/arch/arm64/include/asm/xen/hypercall.h
>> +++ b/arch/arm64/include/asm/xen/hypercall.h
>> @@ -1 +1,29 @@
>> +#ifndef _ASM_ARM64_XEN_HYPERCALL_H
>> +#define _ASM_ARM64_XEN_HYPERCALL_H
>>   #include <xen/arm/hypercall.h>
>> +#include <linux/uaccess.h>
>> +
>> +static inline long privcmd_call(unsigned int call, unsigned long a1,
>> +                unsigned long a2, unsigned long a3,
>> +                unsigned long a4, unsigned long a5)
>
> I realize that privcmd_call is the only hypercall using Software PAN
> at the moment. However, dm_op needs the same as hypercall will be
> issued from userspace as well.

And dm_op() won't be the only example as we continue in cleaning up the
gaping hole that is privcmd.

> So I was wondering whether we should create a generic function (e.g.
> do_xen_hypercall() or do_xen_user_hypercall()) to cover the two
> hypercalls?

Probably a good idea.

~Andrew