linux-kernel - Re: [PATCH 04/15] perf tools: Add map_groups to 'struct addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191129151733.GC26963@kernel.org>
Date:   Fri, 29 Nov 2019 12:17:33 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Clark Williams <williams@...hat.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 04/15] perf tools: Add map_groups to 'struct
 addr_location'

Em Fri, Nov 29, 2019 at 02:40:56PM +0100, Jiri Olsa escreveu:
> On Tue, Nov 12, 2019 at 03:37:46PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> > 
> > From there we can get al->mg->machine, so replace that field with the
> > more useful 'struct map_groups' that for now we're obtaining from
> > al->map->groups, and that is one thing getting into the way of maps
> > being fully shareable.
> > 
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Andi Kleen <ak@...ux.intel.com>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Link: https://lkml.kernel.org/n/tip-4qdducrm32tgrjupcp0kjh1e@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > ---
> >  tools/perf/util/callchain.c                          |  6 +++---
> >  tools/perf/util/db-export.c                          | 12 ++++++------
> >  tools/perf/util/event.c                              |  6 +++---
> >  .../perf/util/scripting-engines/trace-event-python.c |  2 +-
> >  tools/perf/util/symbol.h                             |  2 +-
> >  5 files changed, 14 insertions(+), 14 deletions(-)
> > 
> > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> > index 9a9b56ed3f0a..89faa644b0bc 100644
> > --- a/tools/perf/util/callchain.c
> > +++ b/tools/perf/util/callchain.c
> > @@ -1119,8 +1119,8 @@ int fill_callchain_info(struct addr_location *al, struct callchain_cursor_node *
> >  			goto out;
> >  	}
> >  
> > -	if (al->map->groups == &al->machine->kmaps) {
> > -		if (machine__is_host(al->machine)) {
> > +	if (al->mg == &al->mg->machine->kmaps) {
> 
> heya, I'm getting segfault because of this change
> 
> perf record --call-graph dwarf ./ex
> 
> 	(gdb) r report --stdio
> 	Program received signal SIGSEGV, Segmentation fault.
> 	fill_callchain_info (al=0x7fffffffa1b0, node=0xcd2bd0, hide_unresolved=false) at util/callchain.c:1122
> 	1122            if (al->maps == &al->maps->machine->kmaps) {
> 	(gdb) p al->maps
> 	$1 = (struct maps *) 0x0
> 
> I wish all those map changes would go through some review,
> I have no idea how the code works now ;-)

ouch, I did tons of tests, obviously some more, and reviewing, would
catch these, my bad, will try and fix this...

And yeah, I reproduced the problem, working on a fix.

- Arnaldo