linux-kernel - Re: [PATCH 4.19 000/306] 4.19.87-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMy_=gVVw656AL5Rih_DJrdrFLoURS-et0+dpJ2cKaw6SQ@mail.gmail.com>
Date:   Fri, 29 Nov 2019 06:46:23 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        lkft-triage@...ts.linaro.org,
        linux- stable <stable@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Jouni Högander <jouni.hogander@...kie.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 4.19 000/306] 4.19.87-stable review

On Thu, Nov 28, 2019 at 8:37 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Nov 28, 2019 at 12:23:41PM +0530, Naresh Kamboju wrote:
> > On Thu, 28 Nov 2019 at 02:25, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 4.19.87 release.
> > > There are 306 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri, 29 Nov 2019 20:18:09 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.87-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Kernel BUG noticed on x86_64 device while booting 4.19.87-rc1 kernel.
> >
> > The problematic patch is,
> >
> > > Jouni Hogander <jouni.hogander@...kie.com>
> > >     net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
> >
> > And this kernel panic is been fixed by below patch,
> >
> > commit 48a322b6f9965b2f1e4ce81af972f0e287b07ed0
> > Author: Eric Dumazet <edumazet@...gle.com>
> > Date:   Wed Nov 20 19:19:07 2019 -0800
> >
> >     net-sysfs: fix netdev_queue_add_kobject() breakage
> >
> >     kobject_put() should only be called in error path.
> >
> >     Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in
> > rx|netdev_queue_add_kobject")
> >     Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> >     Cc: Jouni Hogander <jouni.hogander@...kie.com>
> >     Signed-off-by: David S. Miller <davem@...emloft.net>
>
> Now queued up, I'll push out -rc2 versions with this fix.
>
> greg k-h

We have also been informed about another regression these two commits
are causing:

https://lore.kernel.org/lkml/ace19af4-7cae-babd-bac5-cd3505dcd874@I-love.SAKURA.ne.jp/

I suggest to drop these two patches from this queue, and give us a
week to shake out the regressions of the change, and once ready, we
can include the complete set of fixes to stable (probably in a week or
two).

Lukas