linux-kernel - Re: [PATCH 4.19 185/306] net: hns3: bugfix for buffer not free problem during resetting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191129222401.GA29788@amd>
Date:   Fri, 29 Nov 2019 23:24:01 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Pavel Machek <pavel@...x.de>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Huazhong Tan <tanhuazhong@...wei.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 185/306] net: hns3: bugfix for buffer not free
 problem during resetting

Hi!

> > > From: Huazhong Tan <tanhuazhong@...wei.com>
> > > 
> > > [ Upstream commit 73b907a083b8a8c1c62cb494bc9fbe6ae086c460 ]
> > > 
> > > When hns3_get_ring_config()/hns3_queue_to_ring()/
> > > hns3_get_vector_ring_chain() failed during resetting, the allocated
> > > memory has not been freed before these three functions return. So
> > > this patch adds error handler in these functions to fix it.
> > 
> > Correct me if I'm wrong, but... this introduces use-after-free:
> > Should it do devm_kfree(&pdev->dev, cur_chain); ?
> 
> I think Sasha tried to backport a fix for this patch, but that fix broke
> the build :(
> 
> If you want to provide a working backport, I'll be glad to take it.

Actually it looks like problem originated in mainline, and there was
more than one problem with this patch.

cda69d244585bc4497d3bb878c22fe2b6ad647c1 should fix it; it needs to be
back-ported, too.

Best regards,
								Pavel
								
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)