linux-kernel - Re: [PATCH] sched: remove noop function task_fork

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191129071352.GA29046@gmail.com>
Date:   Fri, 29 Nov 2019 08:13:52 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: remove noop function task_fork_dl


* Tom Rix <trix@...hat.com> wrote:

> 
> task_fork_dl is an empty function used only for dl's
> sched_class.task_fork.  Removing it cleans up the code a bit
> and saves a function call in sched_fork.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  kernel/sched/deadline.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index a8a08030a8f7..fbafd97d883a 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1821,14 +1821,6 @@ static void task_tick_dl(struct rq *rq, struct task_struct *p, int queued)
>          start_hrtick_dl(rq, p);
>  }
>  
> -static void task_fork_dl(struct task_struct *p)
> -{
> -    /*
> -     * SCHED_DEADLINE tasks cannot fork and this is achieved through
> -     * sched_fork()
> -     */
> -}
> -
>  #ifdef CONFIG_SMP
>  
>  /* Only try algorithms three times */
> @@ -2451,8 +2443,6 @@ const struct sched_class dl_sched_class = {
>  #endif
>  
>      .task_tick        = task_tick_dl,
> -    .task_fork              = task_fork_dl,
> -
>      .prio_changed           = prio_changed_dl,
>      .switched_from        = switched_from_dl,
>      .switched_to        = switched_to_dl,

Patch got whitespace-damaged - please see Documentation/process/email-clients.rst
of how to send patches with your mail client.

Your patch looks good otherwise.

Thanks,

	Ingo