linux-kernel - Re: [i4passt] [PATCH 1/5] staging/qlge: remove initialising of static local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cac212e9-2412-7919-223c-0193df74ba2a@cs.fau.de>
Date:   Fri, 29 Nov 2019 08:17:52 +0100
From:   Tobias Langer <langer@...fau.de>
To:     Dorothea Ehrl <dorothea.ehrl@....de>, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, gregkh@...uxfoundation.org,
        netdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Cc:     Vanessa Hack <vanessa.hack@....de>, linux-kernel@...cs.fau.de
Subject: Re: [i4passt] [PATCH 1/5] staging/qlge: remove initialising of static
 local variable

Hi,

the patch series looks fine to me, I think you can go ahead and send it
to the kernel.

Kind regards
Tobias

On 27.11.19 13:30, Dorothea Ehrl wrote:
> This patch fixes "ERROR: do not initialise statics to 0" by checkpatch.pl.
> 
> Signed-off-by: Dorothea Ehrl <dorothea.ehrl@....de>
> Co-developed-by: Vanessa Hack <vanessa.hack@....de>
> Signed-off-by: Vanessa Hack <vanessa.hack@....de>
> ---
>  drivers/staging/qlge/qlge_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 6ad4515311f7..587102aa7fbf 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -4578,7 +4578,7 @@ static int qlge_probe(struct pci_dev *pdev,
>  {
>  	struct net_device *ndev = NULL;
>  	struct ql_adapter *qdev = NULL;
> -	static int cards_found = 0;
> +	static int cards_found;
>  	int err = 0;
> 
>  	ndev = alloc_etherdev_mq(sizeof(struct ql_adapter),
> --
> 2.20.1
> 


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5942 bytes)