linux-kernel - RE: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR10MB25580BD5E67CF718E6D06B1083410@VI1PR10MB2558.EURPRD10.PROD.OUTLOOK.COM>
Date:   Sat, 30 Nov 2019 06:41:29 +0000
From:   "Haener, Michael" <michael.haener@...mens.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to
 critclk_systems DMI table


> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Freitag, 29. November 2019 11:16
> To: Häner, Michael (SI BP R&D ZG FW CCP) <michael.haener@...mens.com>
> Cc: Andy Shevchenko <andy@...radead.org>; Darren Hart
> <dvhart@...radead.org>; Platform Driver <platform-driver-
> x86@...r.kernel.org>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>
> Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300
> to critclk_systems DMI table
> 
> On Fri, Nov 29, 2019 at 11:19 AM Michael Haener
> <michael.haener@...mens.com> wrote:
> >
> > The CONNECT X300 uses the PMC clock for on-board components and gets
> > stuck during boot if the clock is disabled. Therefore, add this
> > device to the critical systems list.
> > Tested on CONNECT X300.
> 
> Thank you for your patch!
> Can you be more specific about the clock (which one? For example plt2)
> and if possible type of hardware IP which is connected to it (for
> example, Realtek Ethernet)?

I'm sorry, I don't have more detailed information. I only identified the bug 
by git bisect.

> 
> > Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> > Signed-off-by: Michael Haener <michael.haener@...mens.com>
> > ---
> >  drivers/platform/x86/pmc_atom.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/platform/x86/pmc_atom.c
> b/drivers/platform/x86/pmc_atom.c
> > index 07d1b911e72f..57f06ca114a6 100644
> > --- a/drivers/platform/x86/pmc_atom.c
> > +++ b/drivers/platform/x86/pmc_atom.c
> > @@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[]
> = {
> >                         DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
> >                 },
> >         },
> > +       {
> > +               .ident = "CONNECT X300",
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> > +                       DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
> > +               },
> > +       },
> > +
> >         { /*sentinel*/ }
> >  };
> >
> > --
> > 2.11.0
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko
With Best Regards,
Michael Haener