linux-kernel - Re: [PATCH] net/mlx5e: Fix build error without IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Nov 2019 07:33:48 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Yevgeny Kliteynik <kliteyn@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>,
        "pablo@...filter.org" <pablo@...filter.org>,
        Eli Cohen <eli@...lanox.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eli Britstein <elibr@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>, Roi Dayan <roid@...lanox.com>
Subject: Re: [PATCH] net/mlx5e: Fix build error without IPV6

On Wed, 2019-11-27 at 11:26 -0800, David Miller wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> Date: Wed, 27 Nov 2019 21:27:00 +0800
> 
> > If IPV6 is not set and CONFIG_MLX5_ESWITCH is y,
> > building fails:
> > 
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:322:5: error:
> redefinition of mlx5e_tc_tun_create_header_ipv6
> >  int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:7:0:
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:67:1: note:
> previous definition of mlx5e_tc_tun_create_header_ipv6 was here
> >  mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
> >  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Use #ifdef to guard this, also move mlx5e_route_lookup_ipv6
> > to cleanup unused warning.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Fixes: e689e998e102 ("net/mlx5e: TC, Stub out ipv6 tun create
> header function")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Saeed et al., how do you want to handle this?
> 

LGTM, I guess you can push this to net since this is dealing with a
build error ?

Thanks in Advance,
Saeed.