linux-kernel - Re: [PATCH 4/6] media: dvb_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Dec 2019 22:24:30 +0530
From:   Amit Choudhary <amitchoudhary2305@...il.com>
To:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] media: dvb_dummy_fe: Fix long lines

Somehow reply got messed up.

On Sun, Dec 1, 2019 at 10:22 PM Amit Choudhary
<amitchoudhary2305@...il.com> wrote:
>
> +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe,
> >
> > +                                            u16 *strength)
>
>
> In my opinion, the arguments on new line should be just below the
> start of arguments on top line. Like this:
> +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend *fe,
> +
> u16 *strength)
>
>
>
> > +               .caps = FE_CAN_FEC_1_2 |
> > +                       FE_CAN_FEC_2_3 |
>
>
> Similarly, here too and other places too:
> +               .caps = FE_CAN_FEC_1_2 |
> +                           FE_CAN_FEC_2_3 |
>
> Regards,
> Amit