linux-kernel - Re: 5.4 Regression in r8169 with jumbo frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24035.32883.173899.812456@wylie.me.uk>
Date:   Sun, 1 Dec 2019 08:57:23 +0000
From:   "Alan J. Wylie" <alan@...ie.me.uk>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>
Subject: Re: 5.4 Regression in r8169 with jumbo frames - packet loss/delays

at 22:37 on Sat 30-Nov-2019 Heiner Kallweit (hkallweit1@...il.com) wrote:

> Thanks for the report. A jumbo fix for one chip version may have
> revealed an issue with another chip version. Could you please try
> the following?
> I checked the vendor driver r8168 and there's no special sequence
> to configure jumbo mode.
> 
> What would be interesting:
> Do you set the (jumbo) MTU before bringing the device up?
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 0b47db2ff..38d212686 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -3873,7 +3873,7 @@ static void rtl_hw_jumbo_enable(struct rtl8169_private *tp)
>  	case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28:
>  		r8168dp_hw_jumbo_enable(tp);
>  		break;
> -	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34:
> +	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33:
>  		r8168e_hw_jumbo_enable(tp);
>  		break;
>  	default:
> -- 
> 2.24.0

That patch fixes the issue for me.

Thanks

Alan

-- 
Alan J. Wylie                                          https://www.wylie.me.uk/

Dance like no-one's watching. / Encrypt like everyone is.
Security is inversely proportional to convenience