| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5de4684e.IaCwhRvrFq8+6GM8%lkp@intel.com>
Date: Mon, 02 Dec 2019 09:26:38 +0800
From: kernel test robot <lkp@...el.com>
To: Saravana Kannan <saravanak@...gle.com>
Cc: LKP <lkp@...ts.01.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Frank Rowand <frowand.list@...il.com>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
philip.li@...el.com
Subject: 5e6669387e ("of/platform: Pause/resume sync state during init
.."): WARNING: CPU: 1 PID: 1 at drivers/base/core.c:688
device_links_supplier_sync_state_resume
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
commit 5e6669387e2287f25f09fd0abd279dae104cfa7e
Author: Saravana Kannan <saravanak@...gle.com>
AuthorDate: Wed Sep 4 14:11:24 2019 -0700
Commit: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CommitDate: Fri Oct 4 17:30:19 2019 +0200
of/platform: Pause/resume sync state during init and of_platform_populate()
When all the top level devices are populated from DT during kernel
init, the supplier devices could be added and probed before the
consumer devices are added and linked to the suppliers. To avoid the
sync_state() callback from being called prematurely, pause the
sync_state() callbacks before populating the devices and resume them
at late_initcall_sync().
Similarly, when children devices are populated from a module using
of_platform_populate(), there could be supplier-consumer dependencies
between the children devices that are populated. To avoid the same
problem with sync_state() being called prematurely, pause and resume
sync_state() callbacks across of_platform_populate().
Signed-off-by: Saravana Kannan <saravanak@...gle.com>
Link: https://lore.kernel.org/r/20190904211126.47518-6-saravanak@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
fc5a251d0f driver core: Add sync_state driver/bus callback
5e6669387e of/platform: Pause/resume sync state during init and of_platform_populate()
b94ae8ad9f Merge tag 'seccomp-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
+-------------------------------------------------------------------------+------------+------------+------------+
| | fc5a251d0f | 5e6669387e | b94ae8ad9f |
+-------------------------------------------------------------------------+------------+------------+------------+
| boot_successes | 35 | 0 | 0 |
| boot_failures | 0 | 11 | 11 |
| WARNING:at_drivers/base/core.c:#device_links_supplier_sync_state_resume | 0 | 11 | 11 |
| EIP:device_links_supplier_sync_state_resume | 0 | 11 | 11 |
+-------------------------------------------------------------------------+------------+------------+------------+
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <lkp@...el.com>
[ 5.695288] ### dt-test ### end of unittest - 219 passed, 1 failed
[ 5.698253] Unregister pv shared memory for cpu 0
[ 5.702549] DEBUG_HOTPLUG_CPU0: CPU 0 is now offline
[ 5.703456] ------------[ cut here ]------------
[ 5.704233] Unmatched sync_state pause/resume!
[ 5.704260] WARNING: CPU: 1 PID: 1 at drivers/base/core.c:688 device_links_supplier_sync_state_resume+0x4f/0x180
[ 5.706900] Modules linked in:
[ 5.707376] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G T 5.4.0-rc1-00005-g5e6669387e228 #1
[ 5.708730] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
[ 5.710111] EIP: device_links_supplier_sync_state_resume+0x4f/0x180
[ 5.711174] Code: 85 c0 75 47 83 05 c8 ec f8 42 01 83 15 cc ec f8 42 00 68 78 cf 40 42 e8 df 75 8e ff 83 05 d0 ec f8 42 01 83 15 d4 ec f8 42 00 <0f> 0b 83 05 d8 ec f8 42 01 83 15 dc ec f8 42 00 58 e9 fb 00 00 00
[ 5.714313] EAX: 00000022 EBX: 2e3be8ad ECX: 91fc3059 EDX: 00000001
[ 5.715302] ESI: 42769f73 EDI: 000016f8 EBP: 40115f24 ESP: 40115f14
[ 5.716316] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010246
[ 5.717378] CR0: 80050033 CR2: ffffffff CR3: 0296c000 CR4: 001406d0
[ 5.718332] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[ 5.719325] DR6: fffe0ff0 DR7: 00000400
[ 5.719943] Call Trace:
[ 5.720376] ? of_core_init+0x1f2/0x1f2
[ 5.720976] ? of_platform_sync_state_init+0x47/0x6d
[ 5.721694] ? do_one_initcall+0x210/0x5ab
[ 5.722338] ? parse_args+0x380/0x760
[ 5.722927] ? kernel_init_freeable+0x2a1/0x484
[ 5.723663] ? kernel_init_freeable+0x2cd/0x484
[ 5.724407] ? rest_init+0x220/0x220
[ 5.725001] ? kernel_init+0x16/0x270
[ 5.725608] ? ret_from_fork+0x2e/0x40
[ 5.726342] ---[ end trace e07e47ab6a227b84 ]---
[ 5.746163] Freeing unused kernel image memory: 2620K
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 32ef9553635ab1236c33951a8bd9b5af1c3b1646 v5.4 --
git bisect good 1c134b198daa81cb689f881dcf2900061914085a # 02:59 G 10 0 0 0 Merge branch 'x86-mm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good d76886972823ce456c0c61cd2284e85668e2131e # 03:20 G 10 0 0 0 Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
git bisect bad a308a7102215a582fc474375648965bc5692894b # 04:24 B 0 11 27 0 Merge tag 'ioremap-5.5' of git://git.infradead.org/users/hch/ioremap
git bisect bad 6a0e20cd8cddd70ae5c1211ebe102d738ff2069b # 04:41 B 0 1 17 0 Merge tag 'riscv/for-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
git bisect good 0dd09bc02c1bad55e92306ca83b38b3cf48b9f40 # 05:04 G 10 0 0 0 Merge tag 'staging-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
git bisect bad 9a3d7fd275be4559277667228902824165153c80 # 05:47 B 0 3 19 0 Merge tag 'driver-core-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect bad f1dfe70b7ff73e1469fd6ea25e89d8a4d2dd1c39 # 07:31 B 0 11 27 0 mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call
git bisect bad e40d38f28c10e3010b2828f2c737b50fb81bda8f # 07:31 B 0 11 27 0 debugfs: remove return value of debugfs_create_x16()
git bisect bad 201e91091b1d47047f55580b5474e1239f4d17aa # 07:31 B 0 11 27 0 sh: add the sh_ prefix to early platform symbols
git bisect good fc5a251d0fd7ca9038bab78a8c97932c8c6ca23b # 07:31 G 11 0 0 0 driver core: Add sync_state driver/bus callback
git bisect bad d4387cd117414ba80230f27a514be5ca4a09cfcc # 07:32 B 0 22 61 0 of: property: Create device links for all child-supplier depencencies
git bisect bad 5e6669387e2287f25f09fd0abd279dae104cfa7e # 07:32 B 0 10 26 0 of/platform: Pause/resume sync state during init and of_platform_populate()
# first bad commit: [5e6669387e2287f25f09fd0abd279dae104cfa7e] of/platform: Pause/resume sync state during init and of_platform_populate()
git bisect good fc5a251d0fd7ca9038bab78a8c97932c8c6ca23b # 07:43 G 31 0 0 0 driver core: Add sync_state driver/bus callback
# extra tests with debug options
# extra tests on head commit of linus/master
git bisect bad b94ae8ad9fe79da61231999f347f79645b909bda # 08:53 B 0 1 17 0 Merge tag 'seccomp-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
# bad: [b94ae8ad9fe79da61231999f347f79645b909bda] Merge tag 'seccomp-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
# extra tests on revert first bad commit
git bisect good fd231e31e9be1a388ad6c2ce5f601aae8d859510 # 09:25 G 11 0 0 0 Revert "of/platform: Pause/resume sync state during init and of_platform_populate()"
# good: [fd231e31e9be1a388ad6c2ce5f601aae8d859510] Revert "of/platform: Pause/resume sync state during init and of_platform_populate()"
# extra tests on linus/master
# duplicated: [b94ae8ad9fe79da61231999f347f79645b909bda] Merge tag 'seccomp-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
# extra tests on linux-next/master
# 119: [419593dad8439007452bb6f267861863b572c520] Add linux-next specific files for 20191129
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/lkp@lists.01.org Intel Corporation
Download attachment "dmesg-yocto-vm-yocto-3bfeebd98b7a:20191202072328:i386-randconfig-e002-20191201:5.4.0-rc1-00005-g5e6669387e228:1.gz" of type "application/gzip" (13993 bytes)
View attachment "reproduce-yocto-vm-yocto-3bfeebd98b7a:20191202072328:i386-randconfig-e002-20191201:5.4.0-rc1-00005-g5e6669387e228:1" of type "text/plain" (932 bytes)
Download attachment "2e57c5fca382a4b94347224fb585b0dfd4e892d1:gcc-7:i386-randconfig-e002-20191201:EIP:device_links_supplier_sync_state_resume.xz" of type "application/x-xz" (8576 bytes)
View attachment "config-5.4.0-rc1-00005-g5e6669387e228" of type "text/plain" (129343 bytes)
Powered by blists - more mailing lists