linux-kernel - Re: [PATCH] arm64: defconfig: Change CONFIG_AT803X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191202083838.GE9767@dragon>
Date:   Mon, 2 Dec 2019 16:38:40 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Oliver Graute <oliver.graute@...il.com>
Cc:     Peng Fan <peng.fan@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        Anson Huang <anson.huang@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        "olof@...om.net" <olof@...om.net>,
        Leonard Crestez <leonard.crestez@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_AT803X_PHY from m to y

On Tue, Nov 26, 2019 at 03:54:50PM +0100, Oliver Graute wrote:
> On 04/11/19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@....com>
> > 
> > With phy-reset-gpios are enabled for i.MX8MM-EVK board, phy
> > will be reset. Without CONFIG_AT803X_PHY as y, board will stop
> > booting in NFS DHCP, because phy is not ready. So mark
> > CONFIG_AT803X_PHY from m to y to make board boot when using nfs rootfs.
> > 
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  arch/arm64/configs/defconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index c9a867ac32d4..cd778c9ea8a4 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -285,7 +285,7 @@ CONFIG_SNI_AVE=y
> >  CONFIG_SNI_NETSEC=y
> >  CONFIG_STMMAC_ETH=m
> >  CONFIG_MDIO_BUS_MUX_MMIOREG=y
> > -CONFIG_AT803X_PHY=m
> > +CONFIG_AT803X_PHY=y
> >  CONFIG_MARVELL_PHY=m
> >  CONFIG_MARVELL_10G_PHY=m
> >  CONFIG_MESON_GXL_PHY=m
> > -- 
> > 2.16.4
> 
> Hello Peng,
> 
> this patch broke my imx8qm nfs setup. With the generic phy driver my
> board is booting fine. But with the AT803X_PHY=y enabled  I'am running
> into the following phy issue. So on my side it looks inverse as on
> yours. What is the best proposal to fix this?

So you are saying your Atheros 8035 device works with generic phy
driver but not with AT803X_PHY driver?  That makes no sense.  Did you
add phy-reset-gpios property for your device?

Shawn

> 
> [    5.550442] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [    5.573206] Sending DHCP requests ...... timed out!
> [   95.339702] IP-Config: Retrying forever (NFS root)...
> [   95.348873] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [   99.438443] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [   99.461206] Sending DHCP requests ...... timed out!
> [  174.419639] IP-Config: Retrying forever (NFS root)...
> [  174.428834] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [  178.542418] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [  178.565206] Sending DHCP requests .....
> [  209.261271] random: crng init done
> [  230.565202] . timed out!
> [  260.577340] IP-Config: Retrying forever (NFS root)...
> [  260.586497] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [  264.686438] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [  264.709206] Sending DHCP requests ...... timed out!
> [  339.259701] IP-Config: Retrying forever (NFS root)...
> [  339.268835] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [  343.374422] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [  343.405206] Sending DHCP requests ...... timed out!
> [  433.171676] IP-Config: Retrying forever (NFS root)...
> [  433.180842] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [  437.294439] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> [  437.317206] Sending DHCP requests ...... timed out!
> [  509.003660] IP-Config: Retrying forever (NFS root)...
> [  509.012836] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> [  513.102416] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> 
> Best Regards,
> 
> Oliver