linux-kernel - Re: [PATCH] platform/chrome: wilco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Dec 2019 12:16:21 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Wen Yang <wenyang@...ux.alibaba.com>,
        Benson Leung <bleung@...omium.org>
Cc:     xlpang@...ux.alibaba.com, Nick Crews <ncrews@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: wilco_ec: fix use after free issue

Hi Wen,

On 30/11/19 14:08, Wen Yang wrote:
> This is caused by dereferencing 'dev_data' after put_device() in
> the telem_device_remove() function.
> This patch just moves the put_device() down a bit to avoid this
> issue.
> 
> Fixes: 1210d1e6bad1 ("platform/chrome: wilco_ec: Add telemetry char device interface")
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
> Cc: Benson Leung <bleung@...omium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Cc: Nick Crews <ncrews@...omium.org>
> Cc: linux-kernel@...r.kernel.org
> ---

Queued for 5.5 as is a fix.

Thanks.
 Enric

>  drivers/platform/chrome/wilco_ec/telemetry.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
> index b9d03c3..1176d54 100644
> --- a/drivers/platform/chrome/wilco_ec/telemetry.c
> +++ b/drivers/platform/chrome/wilco_ec/telemetry.c
> @@ -406,8 +406,8 @@ static int telem_device_remove(struct platform_device *pdev)
>  	struct telem_device_data *dev_data = platform_get_drvdata(pdev);
>  
>  	cdev_device_del(&dev_data->cdev, &dev_data->dev);
> -	put_device(&dev_data->dev);
>  	ida_simple_remove(&telem_ida, MINOR(dev_data->dev.devt));
> +	put_device(&dev_data->dev);
>  
>  	return 0;
>  }
>