linux-kernel - Re: [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Dec 2019 07:03:59 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     <jacek.anaszewski@...il.com>, <pavel@....cz>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the
 lp5562 channel node

Shawn

On 12/2/19 3:06 AM, Shawn Guo wrote:
> On Thu, Nov 14, 2019 at 07:30:14AM -0600, Dan Murphy wrote:
>> Add the reg property to each channel node.  This update is
>> to accomodate the multicolor framework.  In addition to the
>> accomodation this allows the LEDs to be placed on any channel
>> and allow designs to skip channels as opposed to requiring
>> sequential order.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> CC: Shawn Guo <shawnguo@...nel.org>
>> CC: Sascha Hauer <s.hauer@...gutronix.de>
>> CC: Pengutronix Kernel Team <kernel@...gutronix.de>
>> CC: Fabio Estevam <festevam@...il.com>
>> CC: NXP Linux Team <linux-imx@....com>
>> ---
>>   arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> index e8d800fec637..efc466ed1fea 100644
>> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -257,29 +257,35 @@
>>   		reg = <0x30>;
>>   		clock-mode = /bits/ 8 <1>;
>>   		status = "disabled";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>>   
>> -		chan0 {
>> +		chan@0 {
> Again, why do not we rename it to led@0 as you update the bindings in
> the last patch in the series?

I am trying to limit the amount of change in this patchset.

I know what you are asking is for a small change but that would be 
another patch to the series to the label.  I want to keep functional 
changes like this isolated from clean up changes like you asked for 
bissectability.

 From that point we can make additional changes. I would really like 
this to get into 5.6 as I thought I hit the merge window for 5.5 but it 
did not make it.

Dan