linux-kernel - Re: [PATCH -next] x86/efi: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b3695b5-8b90-cb7b-6b12-d340ab1dbf8b@linux.vnet.ibm.com>
Date:   Mon, 2 Dec 2019 09:38:14 -0500
From:   Nayna <nayna@...ux.vnet.ibm.com>
To:     YueHaibing <yuehaibing@...wei.com>, jmorris@...ei.org,
        serge@...lyn.com, nayna@...ux.ibm.com, zohar@...ux.ibm.com,
        dhowells@...hat.com, jwboyer@...oraproject.org
Cc:     linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] x86/efi: remove unused variables


On 11/15/19 8:08 AM, YueHaibing wrote:
> commit ad723674d675 ("x86/efi: move common keyring
> handler functions to new file") leave this unused.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   security/integrity/platform_certs/load_uefi.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index 4369204..111898a 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -11,11 +11,6 @@
>   #include "../integrity.h"
>   #include "keyring_handler.h"
>   
> -static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
> -static efi_guid_t efi_cert_x509_sha256_guid __initdata =
> -	EFI_CERT_X509_SHA256_GUID;
> -static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
> -
>   /*
>    * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
>    * it does.


Thanks for noticing and fixing this.

Thanks & Regards,

      - Nayna