linux-kernel - Re: [alsa-devel] [PATCH] ASoC: Intel: sst: Add missing include <linux/io.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Dec 2019 11:32:18 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     YueHaibing <yuehaibing@...wei.com>, cezary.rojewski@...el.com,
        liam.r.girdwood@...ux.intel.com, yang.jie@...ux.intel.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
        gregkh@...uxfoundation.org, allison@...utok.net,
        tglx@...utronix.de, alexios.zavras@...el.com
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: sst: Add missing include
 <linux/io.h>



On 11/28/19 7:58 AM, YueHaibing wrote:
> Fix build error:
> 
> sound/soc/intel/atom/sst/sst.c: In function intel_sst_interrupt_mrfld:
> sound/soc/intel/atom/sst/sst.c:93:5: error: implicit declaration of function memcpy_fromio;
>   did you mean memcpy32_fromio? [-Werror=implicit-function-declaration]
>       memcpy_fromio(msg->mailbox_data,
>       ^~~~~~~~~~~~~
>       memcpy32_fromio
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

that looks legit, we had similar reports for SoundWire.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>   sound/soc/intel/atom/sst/sst.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c
> index fbecbb7..68bcec5 100644
> --- a/sound/soc/intel/atom/sst/sst.c
> +++ b/sound/soc/intel/atom/sst/sst.c
> @@ -14,6 +14,7 @@
>   #include <linux/module.h>
>   #include <linux/fs.h>
>   #include <linux/interrupt.h>
> +#include <linux/io.h>
>   #include <linux/firmware.h>
>   #include <linux/pm_runtime.h>
>   #include <linux/pm_qos.h>
>