linux-kernel - Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field

Open Source and information security mailing list archives

Message-ID: <CADnq5_NLq7HJ6OAAW6yO9G6NC9Ytpd7mzG8TrRmsLsvHbO9wWg@mail.gmail.com>
Date:   Mon, 2 Dec 2019 16:25:09 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harry Wentland <hwentlan@....com>
Cc:     Colin King <colin.king@...onical.com>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Zhou <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field

Applied.  thanks!

Alex

On Wed, Nov 27, 2019 at 11:51 AM Harry Wentland <hwentlan@....com> wrote:
>
> On 2019-11-20 12:22 p.m., Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > The msg_id field is being assigned twice. Fix this by replacing the second
> > assignment with an assignment to msg_size.
> >
> > Addresses-Coverity: ("Unused value")
> > Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
>
> Reviewed-by: Harry Wentland <harry.wentland>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > index 2dd5feec8e6c..6791c5844e43 100644
> > --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp,
> >       in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> >       in->process.msg2_desc.msg_size = 0;
> >       in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> > -     in->process.msg3_desc.msg_id = 0;
> > +     in->process.msg3_desc.msg_size = 0;
> >  }
> >  enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp)
> >  {
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives