linux-kernel - Re: [PATCH] ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e94676c8-b759-6a30-8ef3-285fc0ba10a4@rock-chips.com>
Date:   Tue, 3 Dec 2019 11:56:43 +0800
From:   Kever Yang <kever.yang@...k-chips.com>
To:     Jack Chen <redchenjs@...mail.com>, heiko@...ech.de
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        robh+dt@...nel.org, Jack Chen <redchenjs@...e.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: rockchip: Add missing cpu operating points for
 rk3288-tinker

Hi Jack,

On 2019/12/2 下午11:35, Jack Chen wrote:
> From: Jack Chen <redchenjs@...e.com>
>
> The Tinker Board / S devices use a special chip variant called rk3288-c
> and use different operating points with a higher max frequency.
>
> So add the missing operating points for Tinker Board / S devices, also
> increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the
> cpu can operate at 1.8 GHz.
>
> Signed-off-by: Jack Chen <redchenjs@...e.com>

This patch looks good to me,


Reviewed-by: Kever Yang <kever.yang@...k-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/boot/dts/rk3288-tinker.dtsi | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
> index 81e4e953d4a4..09e83b3d5e7d 100644
> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
> @@ -113,6 +113,17 @@
>   	cpu0-supply = <&vdd_cpu>;
>   };
>   
> +&cpu_opp_table {
> +	opp-1704000000 {
> +		opp-hz = /bits/ 64 <1704000000>;
> +		opp-microvolt = <1350000>;
> +	};
> +	opp-1800000000 {
> +		opp-hz = /bits/ 64 <1800000000>;
> +		opp-microvolt = <1400000>;
> +	};
> +};
> +
>   &gmac {
>   	assigned-clocks = <&cru SCLK_MAC>;
>   	assigned-clock-parents = <&ext_gmac>;
> @@ -175,7 +186,7 @@
>   				regulator-always-on;
>   				regulator-boot-on;
>   				regulator-min-microvolt = <750000>;
> -				regulator-max-microvolt = <1350000>;
> +				regulator-max-microvolt = <1400000>;
>   				regulator-name = "vdd_arm";
>   				regulator-ramp-delay = <6000>;
>   				regulator-state-mem {