linux-kernel - Re: [PATCH v2 2/3] i2c: at91: fix clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191203070121.ebba7qc7mvo6jcgy@M43218.corp.atmel.com>
Date:   Tue, 3 Dec 2019 08:01:21 +0100
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Eugen Hristev - M18282 <Eugen.Hristev@...rochip.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peda@...ntia.se" <peda@...ntia.se>,
        "Codrin Ciubotariu - M19940" <Codrin.Ciubotariu@...rochip.com>,
        Nicolas Ferre - M43238 <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH v2 2/3] i2c: at91: fix clk_offset for sam9x60

On Mon, Dec 02, 2019 at 10:01:17AM +0100, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@...rochip.com>
> 
> In SAM9X60 datasheet, FLEX_TWI_CWGR register rescription mentions clock

typo here: description

> offset of 3 cycles (compared to 4 in eg. SAMA5D3).
> This is the same offset as in SAMA5D2.
> 
> Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
> Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Thanks

> ---
> 
> Sorry, wrong subject line. Modified to SAM9X60 .
> 
> 
>  drivers/i2c/busses/i2c-at91-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
> index e13af48..5137e62 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -174,7 +174,7 @@ static struct at91_twi_pdata sama5d2_config = {
>  
>  static struct at91_twi_pdata sam9x60_config = {
>  	.clk_max_div = 7,
> -	.clk_offset = 4,
> +	.clk_offset = 3,
>  	.has_unre_flag = true,
>  	.has_alt_cmd = true,
>  	.has_hold_field = true,
> -- 
> 2.7.4
>