linux-kernel - Re: [PATCH v7 1/2] loop: Report EOPNOTSUPP properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d4508c7-a3fc-67f6-392e-50a6247898aa@acm.org>
Date:   Mon, 2 Dec 2019 16:48:56 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Evan Green <evgreen@...omium.org>, Jens Axboe <axboe@...nel.dk>,
        Martin K Petersen <martin.petersen@...cle.com>
Cc:     Gwendal Grignou <gwendal@...omium.org>,
        Christoph Hellwig <hch@...radead.org>,
        Ming Lei <ming.lei@...hat.com>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Alexis Savery <asavery@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/2] loop: Report EOPNOTSUPP properly

On 11/14/19 3:50 PM, Evan Green wrote:
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index ef6e251857c8..6a9fe1f9fe84 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -461,7 +461,7 @@ static void lo_complete_rq(struct request *rq)
>   	if (!cmd->use_aio || cmd->ret < 0 || cmd->ret == blk_rq_bytes(rq) ||
>   	    req_op(rq) != REQ_OP_READ) {
>   		if (cmd->ret < 0)
> -			ret = BLK_STS_IOERR;
> +			ret = errno_to_blk_status(cmd->ret);
>   		goto end_io;
>   	}
>   
> @@ -1950,7 +1950,10 @@ static void loop_handle_cmd(struct loop_cmd *cmd)
>    failed:
>   	/* complete non-aio request */
>   	if (!cmd->use_aio || ret) {
> -		cmd->ret = ret ? -EIO : 0;
> +		if (ret == -EOPNOTSUPP)
> +			cmd->ret = ret;
> +		else
> +			cmd->ret = ret ? -EIO : 0;
>   		blk_mq_complete_request(rq);
>   	}
>   }

Reviewed-by: Bart Van Assche <bvanassche@....org>