linux-kernel - Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191203093334.GB624164@phenom.ffwll.local>
Date:   Tue, 3 Dec 2019 10:33:34 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Lyude Paul <lyude@...hat.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/dp_mst: Fix build on systems with
 STACKTRACE_SUPPORT=n

On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@...hat.com>
> 
> I'll go ahead and push this to drm-misc-next, thanks!

drm-misc-next-fixes since it's in the merge window. drm-misc-next is for
5.6 already.
-Daniel

> 
> On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@...ck-us.net> wrote:
> > > On systems with STACKTRACE_SUPPORT=n, we get:
> > > 
> > > WARNING: unmet direct dependencies detected for STACKTRACE
> > >   Depends on [n]: STACKTRACE_SUPPORT
> > >   Selected by [y]:
> > >   - STACKDEPOT [=y]
> > > 
> > > and build errors such as:
> > > 
> > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > > (.text+0x11c): undefined reference to `save_stack_trace'
> > > 
> > > Add the missing deendency on STACKTRACE_SUPPORT.
> > > 
> > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for
> > > debugging")
> > > Cc: Lyude Paul <lyude@...hat.com>
> > > Cc: Sean Paul <sean@...rly.run>
> > > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > 
> > Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > 
> > Gr{oetje,eeting}s,
> > 
> >                         Geert
> > 
> -- 
> Cheers,
> 	Lyude Paul
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch