linux-kernel - fsl,p2020-esdhc sdhci quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8afd0f53-eba8-e000-d8cc-b464e65850c3@rasmusvillemoes.dk>
Date:   Tue, 3 Dec 2019 11:15:37 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Yinbo Zhu <yinbo.zhu@....com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: fsl,p2020-esdhc sdhci quirks

Hi

Commits

05cb6b2a66fa - mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358
support
a46e42712596 - mmc: sdhci-of-esdhc: add erratum eSDHC5 support

seem a bit odd, in that they set bits from the SDHCI_* namespace in the
->quirks2 member:

                host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
                host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;

These are bits 10 and 12, so they are also known as
SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD and
SDHCI_QUIRK2_TUNING_WORK_AROUND. So if the fixes are correct, one should
use those names on the right-hand side, but it seems just as likely (I
can't figure that out from the commit messages) that the left-hand sides
should have been host->quirks ?

Rasmus